krew-index icon indicating copy to clipboard operation
krew-index copied to clipboard

Add kubectl-kount plugin

Open adityajoshi12 opened this issue 3 years ago • 13 comments
trafficstars

adityajoshi12 avatar Sep 17 '22 11:09 adityajoshi12

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience! /kind new-plugin

ahmetb avatar Sep 17 '22 11:09 ahmetb

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: adityajoshi12 / name: Aditya Joshi (0894f202cc8f6eafe4e8eeedf243ac159ea5a97d)

Welcome @adityajoshi12!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 17 '22 11:09 k8s-ci-robot

/assign @ahmetb

adityajoshi12 avatar Sep 17 '22 12:09 adityajoshi12

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adityajoshi12 Once this PR has been reviewed and has the lgtm label, please ask for approval from ahmetb by writing /assign @ahmetb in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 17 '22 12:09 k8s-ci-robot

/assign @ahmetb

adityajoshi12 avatar Sep 20 '22 16:09 adityajoshi12

I've just had a chance to use the plugin and I'm afraid it doesn't meet the usefulness criteria. It doesn't do anything more interesting than kubectl get -n NAMESAPCE RESOURCE_TYPE | wc -l. We typically reject plugins that are easily achievable with such one-liner commands.

ahmetb avatar Sep 20 '22 17:09 ahmetb

/close

ahmetb avatar Sep 20 '22 17:09 ahmetb

@ahmetb: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 20 '22 17:09 k8s-ci-robot

This is just the initial release, next release is going to have have more features like detailed view and group by namespaces.

adityajoshi12 avatar Sep 20 '22 17:09 adityajoshi12

/reopen

adityajoshi12 avatar Sep 20 '22 17:09 adityajoshi12

@adityajoshi12: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 20 '22 17:09 k8s-ci-robot

Understood, but you should consider submitting the plugin when that becomes the case. As it stands right now, the plugin doesn't meet the usefulness criteria. Also, I recommend you to think more broadly in terms of querying/grouping objects besides just counting. In that case, "kount" name no longer becomes useful either. So please take more time developing your plugin, which may help you better understand what you want to build and what to name it.

ahmetb avatar Sep 20 '22 17:09 ahmetb

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 19 '22 17:12 k8s-triage-robot

/close as it's not a fit yet.

ahmetb avatar Dec 20 '22 03:12 ahmetb

@ahmetb: Closed this PR.

In response to this:

/close as it's not a fit yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 20 '22 03:12 k8s-ci-robot