kind
kind copied to clipboard
kubernetes-sigs
Use `ImplementationSpecific` instead of `Prefix` for pathType example
Since the example is using a regular express to match more than the prefix I think the recommendation would be to use
ImplementationSpecific instead. You receive:
❯ k apply -f ingress.yml
Warning: path /httpbin(/|$)(.*) cannot be used with pathType Prefix
When doing that.
Welcome @sontek!
It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kind has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sontek Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @sontek. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Thanks for your report.
This is because in the new version of the ingress-nginx project, some restrictions have been added to avoid security issues.
/lgtm
@sontek: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/ok-to-test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@tao12345666333 @neolit123 Looks like we need more than the lgtm to get this merged
unfortunately the ingress section grew organically and there are multiple implementations, is this compatible with all of them?
https://github.com/kubernetes-sigs/kind/pull/3281
@aojea I'm cutting it down to ingress-nginx and linking out to other guides, we should use whatever is appropriate for ingress-nginx and punt on the others for now https://github.com/kubernetes-sigs/kind/pull/3672
The proposed changes in this PR fixes #3356 and has the correct implementation that fixes the warning of ingress-nginx with 0 colateral damage.
The proposed changes in this PR fixes #3356 and has the correct implementation that fixes the warning of ingress-nginx with 0 colateral damage.
it does not guarantee to work for other ingresses
Quote from the docs:
Deploy an Ingress controller, we document Ingress NGINX here but other ingresses may work including Contour and Kong, you should follow their docs if you choose to use them. ... Note, this example uses an nginx-specific Ingress annotation which may not be supported by all Ingress implementations.
It's kind of misleading if the user guide says that it's documenting "Ingress NGINX", but fails to do so. To me, as a lay user learning this tool, the guide should be consistent.
Don't get me wrong, I'm just trying to collaborate (as a lay user). Thank you all for the tool and the documentation :)
#3763 address this issue, has the same proposed solution, was submitted 1 year later and got merged. So, this PR should be closed.
Sorry this was missed when the new PRs came through. Glad the issue is resolved though. Thanks for the PR and the work on this.
/close
@stmcginnis: Closed this PR.
In response to this:
Sorry this was missed when the new PRs came through. Glad the issue is resolved though. Thanks for the PR and the work on this.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
we are going to change the section to have a better UX and focus on the standard API https://github.com/kubernetes-sigs/kind/pull/3767