kernel-module-management
kernel-module-management copied to clipboard
Changing MIC controller updateStatusByPullPods to support new
ImagePuller interface
Since adding GetPullPodStatus interface to ImgaePuller, which returns the status of the Pod based on its Phase, container's status etc', the MIC controller has no need to look at the pod itself, but to just pass it to ImagePuller, and act based on the status returned. In addition, this PR also adds debug logs to updateStatusByMBSC function
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yevgeny-shnaidman
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [yevgeny-shnaidman]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/assign @ybettan
Deploy Preview for kubernetes-sigs-kmm ready!
| Name | Link |
|---|---|
| Latest commit | 70d6b62ae2d7cebb47dbb9c34b7914859af1a7d3 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/67ea606782b9360008aa1e99 |
| Deploy Preview | https://deploy-preview-1065--kubernetes-sigs-kmm.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.42%. Comparing base (
fa23a9b) to head (70d6b62). Report is 246 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 79.09% 74.42% -4.68%
==========================================
Files 51 77 +26
Lines 5109 6885 +1776
==========================================
+ Hits 4041 5124 +1083
- Misses 882 1549 +667
- Partials 186 212 +26
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Can we please shorten the commit title (it is leaking).
Also, there is a small typo in the commit message, I would change it to:
Since adding GetPullPodStatus method to the ImgaePuller interface, which returns the status of the Pod based on its Phase, container's status etc', the MIC controller has no need to look at the pod itself, but to just pass it to ImagePuller, and act based on the status returned. In addition, this PR also adds debug logs to updateStatusByMBSC function
/lgtm