kernel-module-management icon indicating copy to clipboard operation
kernel-module-management copied to clipboard

Switching KMM to work with the new build/sign flow

Open yevgeny-shnaidman opened this issue 8 months ago • 3 comments

changing the manager's main to use MIC and MBSC reconcilers instead of BuildSignReconciler

yevgeny-shnaidman avatar Mar 27 '25 15:03 yevgeny-shnaidman

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [yevgeny-shnaidman]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 27 '25 15:03 k8s-ci-robot

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
Latest commit 3ce9831b96e8c05cb5d56f19602e5d9d9d4cb0c6
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/67ebd0509b3b6600082da398
Deploy Preview https://deploy-preview-1060--kubernetes-sigs-kmm.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 27 '25 15:03 netlify[bot]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (fa23a9b) to head (3ce9831). Report is 248 commits behind head on main.

Files with missing lines Patch % Lines
cmd/manager/main.go 0.00% 10 Missing :warning:
internal/controllers/mbsc_reconciler.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   79.09%   74.63%   -4.46%     
==========================================
  Files          51       77      +26     
  Lines        5109     6865    +1756     
==========================================
+ Hits         4041     5124    +1083     
- Misses        882     1529     +647     
- Partials      186      212      +26     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Mar 27 '25 15:03 codecov-commenter

/lgtm

ybettan avatar Apr 02 '25 06:04 ybettan