image-builder
image-builder copied to clipboard
kubernetes-sigs
Adding support for Kubevirt capi images
What this PR does / why we need it: Add support for kubevirt images(structured as qemu file in a container image) using the command "make build-kubevirt-qemu-ubuntu-2004" inside "images/capi".
Which issue(s) this PR fixes (optional, in fixes #
Additional context Add any other context for the reviewers
Welcome @isaacdorfman!
It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @isaacdorfman. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Another thought. The PR https://github.com/kubernetes-sigs/image-builder/pull/829 removes the flatcar as a second builder in packer.json but rather uses a separate file to define it. https://github.com/kubernetes-sigs/image-builder/pull/829#pullrequestreview-935225813
Do you think this would be suitable for this PR too?
@seanschneeweiss Hi, I rebased the PR and I think your comments got resolved after the rebase.
@seanschneeweiss Hi, I rebased the PR and I think your comments got resolved after the rebase.
I think the open comments are still valid. Content was added to images/capi/packer/qemu/packer.json that was actually removed in a prior PR #829.
The pull-azure-sigs tests fail on the error:
==> sig-flatcar: Error: network.VirtualNetworksClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Code="InUseSubnetCannotBeDeleted" Message="Subnet pkrsn2tgdnpoxoh is in use by /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/pkr-Resource-Group-2tgdnpoxoh/providers/Microsoft.Network/networkInterfaces/pkrni2tgdnpoxoh/ipConfigurations/ipconfig and cannot be deleted. In order to delete the subnet, delete all the resources within the subnet. See aka.ms/deletesubnet." Details=[] ==> sig-flatcar:[0m
This seems like a problem in the environment.
@seanschneeweiss @davidvossel I fixed the comments and rebased. Please take a look.
@seanschneeweiss @davidvossel All tests pass and I fixed all comments.
@davidvossel @seanschneeweiss I deleted the guest agent and moved it's addition into a separate PR: https://github.com/kubernetes-sigs/image-builder/pull/980
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: isaacdorfman, kkeshavamurthy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~images/capi/OWNERS~~ [kkeshavamurthy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Ova pull seems to fail due to
[1;31m==> vsphere-clone: bash: curl: command not found[0m
[1;31m==> vsphere-clone: bash: wget: command not found[0m
[1;31m==> vsphere-clone: chmod: cannot access '/tmp/goss-0.3.16-linux-amd64': No such file or directory[0m
This seems to be related to https://github.com/kubernetes-sigs/image-builder/pull/983 Probably a rebase fixes this.