image-builder
image-builder copied to clipboard
kubernetes-sigs
Add Windows 23H2 Datacenter offering as Windows Annual Channel for Azure
Change description
- Based off of https://github.com/kubernetes-sigs/image-builder/pull/1353/files; this PR aims to add
23h2-datacenter-coreas Windows Annual Channel with containers for SIG and VHD Image.
Related issues
- Fixes #
Additional context
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
sorry for the confusion, We want both sig and vhd versions of the make command, the latest updates look right for the sig, but will need to also add the vhd command to the make file
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
- :white_check_mark: login: nawazkh / name: Nawaz K (fd2614d3c318fb695864eb0255e32707936787e2)
- :x: The email address for the commit (213349152f678254784a899254e82f118be88331) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
- ✅ login: nawazkh / name: Nawaz K (fd2614d)
- ❌ The email address for the commit (2133491) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.
Pushed commit from my dev VM, will squash and push from local machine.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@nawazkh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-azure-vhds | 213349152f678254784a899254e82f118be88331 | link | true | /test pull-azure-vhds |
| pull-ova-all | 213349152f678254784a899254e82f118be88331 | link | false | /test pull-ova-all |
| pull-azure-sigs | 213349152f678254784a899254e82f118be88331 | link | false | /test pull-azure-sigs |
| pull-gcp-all | 213349152f678254784a899254e82f118be88331 | link | true | /test pull-gcp-all |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@nawazkh: Closed this PR.
In response to this:
I won't be able to get to this for now. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.