kubernetes-sigs
proxmox-ubuntu-22.04: Make boot command wait times more robust
This increases the wait times after pressing Enter key from 5 second to 10 seconds during the boot command insertion, which more results in more robust VM startup process. Previous value of 5 seconds can result in failure due to insufficient wait time:
==> proxmox-iso.ubuntu-2204: Typing the boot command
==> proxmox-iso.ubuntu-2204: Error running boot command:
Put "https://10.9.1.0:8006/api2/json/nodes/pm0/qemu/104/sendkey": EOF
- :x: - login: @tbabej / name: Tomas Babej . The commit (6794dc1c1da446fd9a59e1cbcfb339da82e7dcd5) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kkeshavamurthy for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @tbabej!
It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @tbabej. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi @tbabej could you sign the CLA please? We can process this change then - seems sensible to me though!
@tbabej could you sign the Kubernetes CLA through the link in the comment above? This looks like a simple change we can merge once that is done. Thanks!
/close
Please re-open this if it’s still an issue and you’ve signed the Kubernetes CLA.
@mboersma: Closed this PR.
In response to this:
/close
Please re-open this if it’s still an issue and you’ve signed the Kubernetes CLA.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.