kubernetes-sigs
frontend : Sidebar : Fixed "Network" Icon inconsistency between Sidebar and ResourceMap
Summary
This PR fixes the inconsistent Network icon in Sidebar and ResourceMap.
Fixes #3485
Changes Made
-Updated the useSidebarItems.ts to use the better mdi, i.e. lan instead of folder-network-outline.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: sidd190 (d23dfb0772321dbbd22cbb311ae766cfe8f06148, 6dc94a34e1395782bc35b0c2d25b5b59eea1235e, bdc488223d1c5d15175912cdb55cfcec71724f02)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @sidd190!
It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mboersma, sidd190, sniok
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sniok]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks @mboersma . Can you run make frontend-fixlint to fix the formatting?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@sidd190 could you do `npm run lint-fix", commit the results, and then squash these commits together so there's only one?