gcp-filestore-csi-driver
gcp-filestore-csi-driver copied to clipboard
kubernetes-sigs
Fix GCP tags UTs to not look for auth
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake
What this PR does / why we need it:
Unit tests written for GCP tags was expecting the creds to be present which should not be case and hence the dependency is removed. And instead for UTs WithoutAuthentication is used.
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
None
Hi @bharath-b-rh. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@leiyiz Could you please add cherry-pick release-1.6 label too, if the changes are satisfactory.
Hi, similar to what I said on the cherry-pick CL, is this necessary to cherry-pick?
Hi, similar to what I said on the cherry-pick CL, is this necessary to cherry-pick?
Yeah, this would be helpful to check unit tests in environment where GCP auth is not provided and since the changes are specific to unit tests, it will not change the actual behavior.
Yeah, this would be helpful to check unit tests in environment where GCP auth is not provided and since the changes are specific to unit tests, it will not change the actual behavior.
Ok, we'll have to take a close look, the GKE backport policy is strict.
Yeah, this would be helpful to check unit tests in environment where GCP auth is not provided and since the changes are specific to unit tests, it will not change the actual behavior.
Ok, we'll have to take a close look, the GKE backport policy is strict.
Thank you!
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@mattcary Could we merge this to master? This has appeared in OpenShift also. We don't need cherry-pick to older versions.
@savirg can you please take a look at https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_gcp-filestore-csi-driver/905/pull-gcp-filestore-csi-driver-verify/1979090876411940864
The verify job is failing due to a change made in a different commit which is being flagged now by the linter.
@savirg can you please take a look at https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_gcp-filestore-csi-driver/905/pull-gcp-filestore-csi-driver-verify/1979090876411940864
Raised https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/pull/1178 to fix this.
