gcp-filestore-csi-driver icon indicating copy to clipboard operation
gcp-filestore-csi-driver copied to clipboard

[release-1.6] issue-567: Support to add ResoureManagerTags to GCP Filestore resources

Open bharath-b-rh opened this issue 1 year ago • 5 comments
trafficstars

This is a manual cherry-pick of https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/pull/630

Driver now supports adding resource tags to the filestore Instance resources created. Users can provide a comma separated list of tags using the new argument --resource-tags.

bharath-b-rh avatar Jun 18 '24 09:06 bharath-b-rh

Hi @bharath-b-rh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 18 '24 09:06 k8s-ci-robot

/cc @pwschuurman @leiyiz

bharath-b-rh avatar Jun 18 '24 10:06 bharath-b-rh

@pwschuurman / @leiyiz Could you please help me with the PR review. This is a cherry-pick of the changes merged in master.

bharath-b-rh avatar Jun 19 '24 13:06 bharath-b-rh

/lgtm /ok-to-test /assign @pwschuurman @leiyiz

dobsonj avatar Jul 09 '24 15:07 dobsonj

/approve /lgtm

leiyiz avatar Jul 31 '24 16:07 leiyiz

/remove lgtm

leiyiz avatar Jul 31 '24 16:07 leiyiz

let's keep the cherry pick PRs clean and don't change them. if there's bug fix needed let's just do separate cherry-picks.

if too much change happened and we can't backport cleanly it might be good to consider cutting a new release branch

leiyiz avatar Jul 31 '24 16:07 leiyiz

let's keep the cherry pick PRs clean and don't change them. if there's bug fix needed let's just do separate cherry-picks.

if too much change happened and we can't backport cleanly it might be good to consider cutting a new release branch

@leiyiz Thank you reviewing the changes!

I have reverted the additional changes. The cherry picks are clean and now contains only the changes from the source commit.

bharath-b-rh avatar Aug 01 '24 06:08 bharath-b-rh

@leiyiz ^^

bharath-b-rh avatar Aug 06 '24 10:08 bharath-b-rh

/lgtm

leiyiz avatar Aug 16 '24 00:08 leiyiz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, leiyiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 16 '24 00:08 k8s-ci-robot