gcp-filestore-csi-driver
gcp-filestore-csi-driver copied to clipboard
[release-1.6] issue-567: Support to add ResoureManagerTags to GCP Filestore resources
This is a manual cherry-pick of https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/pull/630
Driver now supports adding resource tags to the filestore Instance resources created. Users can provide a comma separated list of tags using the new argument --resource-tags.
Hi @bharath-b-rh. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/cc @pwschuurman @leiyiz
@pwschuurman / @leiyiz Could you please help me with the PR review. This is a cherry-pick of the changes merged in master.
/lgtm /ok-to-test /assign @pwschuurman @leiyiz
/approve /lgtm
/remove lgtm
let's keep the cherry pick PRs clean and don't change them. if there's bug fix needed let's just do separate cherry-picks.
if too much change happened and we can't backport cleanly it might be good to consider cutting a new release branch
let's keep the cherry pick PRs clean and don't change them. if there's bug fix needed let's just do separate cherry-picks.
if too much change happened and we can't backport cleanly it might be good to consider cutting a new release branch
@leiyiz Thank you reviewing the changes!
I have reverted the additional changes. The cherry picks are clean and now contains only the changes from the source commit.
@leiyiz ^^
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bharath-b-rh, leiyiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [leiyiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment