gcp-filestore-csi-driver icon indicating copy to clipboard operation
gcp-filestore-csi-driver copied to clipboard

filter out instances in different vpc networks

Open tyuchn opened this issue 3 years ago • 6 comments
trafficstars

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it: filter out instances in different vpc networks at ip reservation step Which issue(s) this PR fixes:

Fixes #b/244645541

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

N/A

tyuchn avatar Sep 02 '22 18:09 tyuchn

Hi @tyuchn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 02 '22 18:09 k8s-ci-robot

/ok-to-test

saikat-royc avatar Sep 02 '22 19:09 saikat-royc

Please ensure to test the PR manually (if not already done)

saikat-royc avatar Sep 02 '22 19:09 saikat-royc

Can you also add some unit test for this?

saikat-royc avatar Sep 02 '22 19:09 saikat-royc

Overall change LGTM

saikat-royc avatar Sep 02 '22 19:09 saikat-royc

Can you also add some unit test for this?

Done

tyuchn avatar Sep 06 '22 19:09 tyuchn

/lgtm /approval

leiyiz avatar Sep 07 '22 20:09 leiyiz

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, tyuchn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 07 '22 20:09 k8s-ci-robot