gcp-filestore-csi-driver icon indicating copy to clipboard operation
gcp-filestore-csi-driver copied to clipboard

fix sc across cluster can point to the same instance pool

Open leiyiz opened this issue 3 years ago • 3 comments
trafficstars

What type of PR is this? /kind bug

What this PR does / why we need it: before this fix multiple clusters can have the same sc, which would point to the same storage pool and cause race conditions. We add 2 more tags to uniquely identify which cluster each instance was managed by. The reason we added 2 tags are because cluster names are unique per location and zone name + cluster name might exceed 63 char.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

if multishare is enabled, the container now requires "--gke-cluster-name" flag to be set

leiyiz avatar Sep 02 '22 01:09 leiyiz

Before submitting this PR we should also verify GKE can actually plumb the cluster name and location to the yamls

saikat-royc avatar Sep 02 '22 18:09 saikat-royc

Please update the description of the PR to provide a background context why these extra tags are needed (also why two separate tags needed)

saikat-royc avatar Sep 02 '22 18:09 saikat-royc

/lgtm /approve

saikat-royc avatar Sep 07 '22 17:09 saikat-royc

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [leiyiz,saikat-royc]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 07 '22 17:09 k8s-ci-robot