gcp-compute-persistent-disk-csi-driver icon indicating copy to clipboard operation
gcp-compute-persistent-disk-csi-driver copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Update LSSD raiding logic to support NVME VMs

Open Sneha-at opened this issue 1 year ago • 5 comments
trafficstars

What type of PR is this? /kind bug

What this PR does / why we need it: This updates the RAIDing logic for Local SSD caching to exclude PDs from raiding. Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: Validated Data cache E2E tests on c3-standard-22-lssd Does this PR introduce a user-facing change?:

NONE

Sneha-at avatar Jun 26 '24 00:06 Sneha-at

/assign @mattcary

Sneha-at avatar Jun 26 '24 02:06 Sneha-at

/lgtm /approve

mattcary avatar Jun 26 '24 19:06 mattcary

/hold running some checks for this

Sneha-at avatar Jun 26 '24 23:06 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 09 '24 20:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 09 '24 22:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 09 '24 23:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 09 '24 23:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 10 '24 19:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 10 '24 21:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 15 '24 23:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 15 '24 23:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 15 '24 23:07 Sneha-at

/unhold

Sneha-at avatar Jul 16 '24 17:07 Sneha-at

/lgtm /approve

mattcary avatar Jul 16 '24 17:07 mattcary

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 16 '24 18:07 Sneha-at

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at avatar Jul 16 '24 18:07 Sneha-at

/lgtm /approve

mattcary avatar Jul 16 '24 20:07 mattcary

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 16 '24 20:07 k8s-ci-robot

@Sneha-at: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e 7eddb8db09da4188c8b16dc7a46c7c4ff254712e link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jul 16 '24 21:07 k8s-ci-robot

e2e test failing due to known issue with snapshot delete operations. Force-merging to work around that.

mattcary avatar Jul 16 '24 22:07 mattcary