gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Conformance tests for HTTPRoute+Gateway HTTPS Listener

Open dprotaso opened this issue 1 year ago • 2 comments

What type of PR is this? /kind cleanup /kind test /area conformance

What this PR does / why we need it:

There's no 'Core' conformance tests that validates the combination of a HTTPRoute with a Gateway HTTPS Listener.

There are other tests but they're 'Extended' and behind various feature flags

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

dprotaso avatar Feb 27 '24 03:02 dprotaso

adding approvers /assign @arkodg @mlavacca @sunjayBhatia

adding reviewers /cc @LiorLieberman @michaelbeaumont @Xunzhuo

dprotaso avatar Mar 07 '24 22:03 dprotaso

Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @LiorLieberman @Xunzhuo

dprotaso avatar Apr 01 '24 20:04 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, dprotaso, frankbu, michaelbeaumont, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 03 '24 12:04 k8s-ci-robot

@sunjayBhatia @mlavacca can you add an /lgtm

dprotaso avatar Apr 05 '24 16:04 dprotaso

/lgtm

sunjayBhatia avatar Apr 08 '24 16:04 sunjayBhatia

/lgtm

sunjayBhatia avatar Apr 08 '24 17:04 sunjayBhatia

CI is being weird - resetting it by re-opening the PR

dprotaso avatar Apr 08 '24 21:04 dprotaso