gateway-api
gateway-api copied to clipboard
kubernetes-sigs
Explain the default for TLSConfig.mode in documentation
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Clarifies that TLSConfig.mode has a default.
It seems the doc generator doesn't look at the kubebuilder:default tag, though it could.
Which issue(s) this PR fixes:
Fixes #2070
Does this PR introduce a user-facing change?:
NONE
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: tommie (0c0c0507806e9fa0092c259032eb008a01c82a87)
- :white_check_mark: login: youngnick / name: Nick Young (94a69a3437661d3ff16569000f97b7577df410f5)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @tommie!
It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @tommie. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Thanks @tommie! This LGTM once the suggestion from @danehans is included.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: arkodg, tommie, youngnick
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [youngnick]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I think this is fine, I'll give this one more day, then LGTM. Ping @robscott and @shaneutt in case they want to take another look.
Oh, sorry, I missed this @tommie. Could you please rebase and then I'll merge?
Oh, sorry, I missed this @tommie. Could you please rebase and then I'll merge?
@youngnick Yepp, done.
@tommie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-gateway-api-verify | 94a69a3437661d3ff16569000f97b7577df410f5 | link | true | /test pull-gateway-api-verify |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Sorry @tommie, I tried to sort this out in the Github UI, but looks like it needs a gofumpt run. Do you want to do it or should I?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
Hi @tommie, we are going through the PRs that have been inactive for a while, as our bot configuration is configured in a pretty loose way and we are trying to perform some cleanup in the open issues and PRs. We really appreciate your effort here, but since this PR has been in stale for a while now, we are closing it.
In case you have an interest, feel free to re-open the PR, rebase and we'll merge it.
/close
@mlavacca: Closed this PR.
In response to this:
Hi @tommie, we are going through the PRs that have been inactive for a while, as our bot configuration is configured in a pretty loose way and we are trying to perform some cleanup in the open issues. We really appreciate your effort here, but since this PR has been in stale for a while now, we are closing it.
In case you have an interest, feel free to re-open the PR, rebase and we'll merge it.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.