kubernetes-sigs
feat(gateway) add support for gateway api experimental ListenerSet
What does it do ?
Support the use of ListenerSetswith Gateway API.
Motivation
Using Gateway API and TLS without ListenerSets requires either wildcard certs or all hosts to be known when creating the gateway, ListenerSets removes with requirement but external-dns does not support them currently.
More
- [x] Yes, this PR title follows Conventional Commits
- [x] Yes, I added unit tests
- [x] Yes, I updated end user documentation accordingly
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: bmhughes / name: Ben Hughes (40b93de945f22fe80b3b3e48fa65e353ab5cb2e9)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @bmhughes!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @bmhughes. Thanks for your PR.
I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Pull Request Test Coverage Report for Build 20059296334
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 165 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.1%) to 78.543%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| apis/externaldns/types.go | 1 | 99.71% |
| store.go | 58 | 39.07% |
| gateway.go | 106 | 79.46% |
| <!-- | Total: | 165 |
| Totals | |
|---|---|
| Change from base Build 20056240751: | -0.1% |
| Covered Lines: | 16084 |
| Relevant Lines: | 20478 |
💛 - Coveralls
Until gateway-api people have defined what to do for DNS we should stop changing. ListenerSet is likely the right thing to do, but not sure about the x-api. Likely gateway-api should stabilize the API before we change the DNS configuration sources.
/hold likely we will not integrate HTTPRoute in the future , but ListenerSet as told by gateway-api. We should wait until they finalized the API and what external-dns should do to integrate.