kubernetes-sigs
feat: add new flag to allow configuring per pod FQDNs for service source.
What does it do ?
Currently if you create FQDNs for K8S headless services, a service source will generate DNS record for the source. Also, in addition to that, if pods related to that service has a hostname configured, then FQDNs for each pod will also be created.
I.e. if you have service service-1 resulting into FQDN service-1.some.domain there will also be FQDNs like pod-1.service-1.some.domain be generated.
With this change
Fixes #5937
Motivation
I need to generate per pod FQDNs for pods created by Deployment.
More
- [x] Yes, this PR title follows Conventional Commits
- [x] Yes, I added unit tests
- [x] Yes, I updated end user documentation accordingly
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: SerjKol80 / name: Sergey Kolosov (214b9164e9e7fd83daf8bda9177c73b9be6fac10)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @SerjKol80!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @SerjKol80. Thanks for your PR.
I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
What for? There is FQDN support https://github.com/kubernetes-sigs/external-dns/blob/master/docs/advanced/fqdn-templating.md. Is way more flexible
What for? There is FQDN support https://github.com/kubernetes-sigs/external-dns/blob/master/docs/advanced/fqdn-templating.md. Is way more flexible
@ivankatliarchuk I'm not sure I got your point. how templating helps me to enable or disable per pods FQDNs for particular service. I.e. today "--source=service" flag will generate tons of DNS records (one per each pod created by StatefulSet). How can I disable it? Or another example: if I want such DNS records for K8s service backed by Deployments' pods. There is no way to do it today. Unless I misunderstood something.
@ivankatliarchuk: Closed this PR.
In response to this:
Closing, as feature supported with
--fqdn-template=""/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ivankatliarchuk Would you please explain deeper how --fqdn-template="" supports what I need? I axplain my thoughts deeper in issue's comment: https://github.com/kubernetes-sigs/external-dns/issues/5937#issuecomment-3504275607
@SerjKol80: Reopened this PR.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
https://github.com/kubernetes-sigs/external-dns/pull/5938#issuecomment-3489939497
/hold
Please provide evidences that --fqdn-template does not support your use case.
Please provide evidences that
--fqdn-templatedoes not support your use case.
@ivankatliarchuk I explained it in deep details in issue comment: https://github.com/kubernetes-sigs/external-dns/issues/5937#issuecomment-3504275607
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.