external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

Upgrade github.com/datawire/ambassador to v1.14.4

Open johngmyers opened this issue 2 years ago • 11 comments

Description

Upgrades github.com/datawire/ambassador to partially address #3789

Checklist

  • [ ] Unit tests updated
  • [ ] End user documentation updated

johngmyers avatar Jul 18 '23 07:07 johngmyers

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johngmyers Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 18 '23 07:07 k8s-ci-robot

Hi, I tried to checkout to your branch and run go mod tidy but I get error regarding the matching hashes.

> go mod tidy
go: downloading github.com/exoscale/egoscale v1.19.0
go: downloading github.com/StackExchange/dnscontrol/v3 v3.31.6
go: downloading github.com/datawire/ambassador v1.14.4
verifying github.com/datawire/[email protected]: checksum mismatch
	downloaded: h1:9Lq6zbABOn3vMxvf04Zehbf3yGoYXtDlCs2wV91yeRw=
	go.sum:     h1:yykAkJeLVZc89BwwMmEObtmL/L32g7ol22Rp64iKCaE=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

matusf avatar Jul 19 '23 13:07 matusf

I removed ambassador from my module cache and re-downloaded it. I still get the yyk checksum.

go mod verify isn't giving me any errors.

johngmyers avatar Jul 21 '23 04:07 johngmyers

yes, after removing it from cache and redownloading I get the same hash. works ok. sorry for confusion

matusf avatar Jul 24 '23 09:07 matusf

@johngmyers Since #3824 is merged, with ambassdor going to v1.12.4, is there still an interest to keep this PR ?

mloiseleur avatar Aug 11 '23 07:08 mloiseleur

We'll need to either upgrade ambassador at some point or we'll need to vendor the CRD type and drop ambassador as a dependency.

johngmyers avatar Aug 11 '23 16:08 johngmyers

/retest

johngmyers avatar Sep 02 '23 22:09 johngmyers

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 13 '23 00:09 k8s-ci-robot

@johngmyers: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-external-dns-licensecheck 5f21cd55992f110ac0ba2ec5faaecd4d2ccfaa50 link true /test pull-external-dns-licensecheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jan 03 '24 18:01 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 02 '24 18:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 02 '24 19:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Jun 01 '24 20:06 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 01 '24 20:06 k8s-ci-robot