external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard
verified publisher icon kubernetes-sigs

New feature: client's certificate-based authentication to Infoblox NIOS server

Open skudriavtsev opened this issue 3 years ago • 7 comments

Description

This PR contains changes for a new feature: client's certificate authentication to Infoblox NIOS server. And some bugfixes as well, including the fix for the issue https://github.com/kubernetes-sigs/external-dns/issues/2198

Fixes #2198

Checklist

  • [ ] Unit tests updated
  • [ ] End user documentation updated

skudriavtsev avatar Jun 22 '22 20:06 skudriavtsev

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skudriavtsev To complete the pull request process, please assign seanmalloy after the PR has been reviewed. You can assign the PR to them by writing /assign @seanmalloy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 22 '22 20:06 k8s-ci-robot

By the way, I would like to put some example YAML-deployment files for Infoblox provider and I found no separate directory for that. Probably I missed something in the project repository's rules ...

To the reviewers: which place of the repository should I put the example files in?

skudriavtsev avatar Jun 27 '22 07:06 skudriavtsev

Hi @Raffo / @njuettner, Can you please review this PR and share your comments ?

ranjishmp avatar Jul 06 '22 12:07 ranjishmp

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: skudriavtsev / name: Sergey Kudriavtsev (f124f6ad316c5b801baf4302b993ec9d8a6ea8f6, 0ad789d384cc3210d4c165ec188f42627a908f0b)
  • :white_check_mark: login: achernevskii / name: Aleksei Chernevskii (cfda29a6588cbd293ee10fed59097f12948387c8, ba945325e184e196515f1ca06ddac969a04091a5)

linux-foundation-easycla[bot] avatar Jul 06 '22 15:07 linux-foundation-easycla[bot]

Hi @Raffo / @njuettner, it will be really great if you can provide your review comments

ranjishmp avatar Jul 12 '22 06:07 ranjishmp

@skudriavtsev: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 18 '22 18:08 k8s-ci-robot

@skudriavtsev Please rebase the PR

ranjishmp avatar Sep 12 '22 04:09 ranjishmp

@alebedev87, thank you for your review, I will address the comments but today I am going to split this PR into 2-3 separate PRs instead of re-basing this one. That is why I just answered 'agree' instead of just accepting your proposals. I will update this PR with exact links.

P.S.: I guess, I will add more comments to the code.

skudriavtsev avatar Oct 06 '22 07:10 skudriavtsev

replaced by new PRs: https://github.com/kubernetes-sigs/external-dns/pull/3067 and https://github.com/skudriavtsev/external-dns-1/pull/4 (which will be rebased to the original repo after the 1-st PR will be merged)

skudriavtsev avatar Oct 06 '22 14:10 skudriavtsev