provider: added k3d provider and node lifecycle handlers
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables a new E2EClusterProvider for k3d based infra.
This change includes the following changes and features.
- Added a new Interface type
E2EClusterProviderWithImageLoaderAndNodeLifecyclewhich can be used to setup providers that extend the cluster lifecycle function around the nodes. - Enabled a
k3dbased provider with support for Node lifecycle management. - Existing Image loader related function and interfaces were augmented with
args ...stringto be able to provide additional arguments in case if the image load handlers need some of the additional config.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I have also extended the E2EClusterProviderWithImageLoader 's Image load related methods to take an additional arg ...string value to account for additional options that one can pass while performing image load operation alone.
This comes in handy with k3d where it provides a few different mode of loading images and cleanup workflows.
This change also doesn't break any existing API contract extended by the envfuncs.
Does this PR introduce a user-facing change?
enabled a new `E2eClusterProvider` for `k3d` that can be used as a new cluster provider for running e2e tests.
Additional documentation e.g., Usage docs, etc.:
NA
/cc @cpanato
go install of k3d is failing due to an issue similar to https://github.com/k3d-io/k3d/issues/1324
/hold
Holding this under the k3d install issue is resolved.
/unhold
/hold
Holding this until @cpanato @vladimirvivien @ShwethaKumbla also takes look
/retest
@vladimirvivien PTAL. I has pushed the requested changes.
@vladimirvivien PTAL when you can. Addressed the required changes in the message for wait for control plane.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
@harshanarayana is this still on your radar for 2025?
I will get this done before we cut the christmas release..
@vladimirvivien @cpanato PTAL. I have reorganised all the providers under third_party as suggested in the comments, and added backward compatibility type alias to make sure we do not break existing behaviours for the users who are already consuming this in some form.
/test pull-e2e-framework-test
/test pull-e2e-framework-test
/test pull-e2e-framework-verify
/test pull-e2e-framework-verify
@harshanarayana rebase after we merge https://github.com/kubernetes-sigs/e2e-framework/pull/480
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, harshanarayana
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [cpanato,harshanarayana]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/unhold