e2e-framework icon indicating copy to clipboard operation
e2e-framework copied to clipboard
verified publisher icon kubernetes-sigs

Do not cache config if not explicitly set

Open phisco opened this issue 1 year ago • 12 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/e2e-framework/issues/352 Fixes https://github.com/kubernetes-sigs/e2e-framework/issues/384

Based on https://github.com/kubernetes-sigs/e2e-framework/pull/396

Special notes for your reviewer:

Based on https://github.com/kubernetes-sigs/e2e-framework/pull/396, but attempting to solve https://github.com/kubernetes-sigs/e2e-framework/pull/396#discussion_r1593786101.

This way we won't have any concurrent writes to the config client, as we are not caching it, the internal client is just for user-injected clients, so that a user can continue avoiding to provide a kubeconfig altogether if not needed. We might want to adjust naming.

Does this PR introduce a user-facing change?

The client won't be cached anymore, I wouldn't call it a user-facing change.

Additional documentation e.g., Usage docs, etc.:

phisco avatar May 08 '24 11:05 phisco

Hi @phisco. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 08 '24 11:05 k8s-ci-robot

/ok-to-test

vladimirvivien avatar May 09 '24 14:05 vladimirvivien

/retest

phisco avatar May 12 '24 08:05 phisco

@vladimirvivien, can you trigger the tests? 🙏

phisco avatar May 23 '24 18:05 phisco

trying pinging @harshanarayana 🙏 😬

phisco avatar May 28 '24 08:05 phisco

Looking into it @phisco

harshanarayana avatar May 28 '24 08:05 harshanarayana

/retest

phisco avatar May 29 '24 13:05 phisco

@phisco @Fricounet Do we still need to keep https://github.com/kubernetes-sigs/e2e-framework/pull/396 alive?

harshanarayana avatar May 31 '24 12:05 harshanarayana

Didn't want to hijack the original pr, just wanted to see if it broke tests, I'm fine closing this one and porting only my commit to #389 🙏

phisco avatar May 31 '24 12:05 phisco

/lgtm

@vladimirvivien @cpanato mind taking a second look on this ?

harshanarayana avatar Jun 26 '24 08:06 harshanarayana

/lgtm

cpanato avatar Jun 26 '24 12:06 cpanato

Thanks @phisco @harshanarayana @cpanato

/lgtm /approve

vladimirvivien avatar Jul 08 '24 14:07 vladimirvivien

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phisco, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 08 '24 14:07 k8s-ci-robot

And thanks @Fricounet for the initial implementation!

phisco avatar Jul 08 '24 19:07 phisco