descheduler icon indicating copy to clipboard operation
descheduler copied to clipboard

bring lownodeutilization and highnodeutilization to plugin

Open JaneLiuL opened this issue 3 years ago • 11 comments
trafficstars

as title

JaneLiuL avatar Aug 10 '22 10:08 JaneLiuL

/unhold

JaneLiuL avatar Aug 11 '22 06:08 JaneLiuL

/assign @ingvagabund

JaneLiuL avatar Aug 11 '22 06:08 JaneLiuL

@ingvagabund coding finish for bring two nodeutilization to plugins, please kindly reivew if you at rest :)

JaneLiuL avatar Aug 11 '22 06:08 JaneLiuL

@pravarag for awareness

ingvagabund avatar Aug 11 '22 14:08 ingvagabund

@pravarag for awareness

Hi @ingvagabund @JaneLiuL does this PR covers what's mentioned here: https://github.com/kubernetes-sigs/descheduler/issues/837#issuecomment-1164511878 ?

I was already in works for bringing LowNodeUtilization and HighNodeUtilization strategies, let me know otherwise. I'll pick something else to work upon.

pravarag avatar Aug 11 '22 15:08 pravarag

hi @pravarag since i check already two months and still not seem your pr, so i just raise pr for that.

JaneLiuL avatar Aug 11 '22 23:08 JaneLiuL

/retest

JaneLiuL avatar Aug 16 '22 08:08 JaneLiuL

@JaneLiuL: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-descheduler-helm-test e2b8cbe4c59e200d67eac86c389b496ae4936b2b link true /test pull-descheduler-helm-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Aug 16 '22 08:08 k8s-ci-robot

@JaneLiuL please let us know when the PR is ready for review :) This is the last strategy in the list.

ingvagabund avatar Aug 16 '22 15:08 ingvagabund

@ingvagabund ok for review now, would you please kindly review this pr ? :)

JaneLiuL avatar Aug 17 '22 00:08 JaneLiuL

/approve /lgtm

@JaneLiuL Thank you for migrating the last plugin

ingvagabund avatar Aug 17 '22 12:08 ingvagabund

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 17 '22 12:08 k8s-ci-robot