kubernetes-sigs
Fix values.yml
- :x: - login: @rabbagliettiandrea / name: Andrea Rabbaglietti . The commit (776da1ff35d60d3c42f228f26855e1a960863e59) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @rabbagliettiandrea!
It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @rabbagliettiandrea. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Can the commit message be changed to something along these lines:
include RemovePodsViolatingTopologySpreadConstraint in DeschedulerPolicy for helm chart
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: damemi, rabbagliettiandrea
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [damemi]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hello @rabbagliettiandrea, thank You for extending the list of strategies in the helm chart. Have you had a chance to setup your CLA?
@rabbagliettiandrea any luck getting the CLA signed? Do you need any assistance with the CLA?
Hi @seanmalloy :) frankly speaking, I'm not very confident to signup a contract that I can barely understand just to do a PR. At the same time, I'm very up to contribute to OSS world.
Thank you for your awesome work guys, Andrea
@rabbagliettiandrea: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-descheduler-test-e2e-k8s-master-1-24 | 776da1ff35d60d3c42f228f26855e1a960863e59 | link | true | /test pull-descheduler-test-e2e-k8s-master-1-24 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
I think we can close this one. Contributor is not willing to sign CLA, and also those files will be different when the new changes for v1alpha2 hit the repo
Will close, but anyone that thinks this should be reopened, feel free to reopen :D
/close
@knelasevero: Closed this PR.
In response to this:
Will close, but anyone that thinks this should be reopened, feel free to reopen :D
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.