descheduler icon indicating copy to clipboard operation
descheduler copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

use v1alpha2 api for helm chart default values

Open a7i opened this issue 2 years ago • 9 comments

I assume this needs a chart bump?

a7i avatar May 05 '23 17:05 a7i

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 08 '23 11:05 k8s-ci-robot

/hold until we decide when it's the default

a7i avatar May 11 '23 15:05 a7i

/label tide/merge-method-squash

a7i avatar Aug 22 '23 22:08 a7i

@JaneLiuL would you please review?

a7i avatar Aug 22 '23 22:08 a7i

/remove-hold

a7i avatar Aug 24 '23 15:08 a7i

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 21 '24 04:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 20 '24 04:02 k8s-triage-robot

Could this please be merged? The difference between the two configs confused me a lot at the start since I didn't notice the version difference.

RedlineTriad avatar Mar 20 '24 09:03 RedlineTriad

Same for me. I installed it yesterday and it works fine but there is big warning in the readme about v1 being deprecated and recommend switching to v2, yet the chart only works with v1.

arthurk avatar Mar 20 '24 10:03 arthurk

Plus one here!

sherifabdlnaby avatar Mar 29 '24 18:03 sherifabdlnaby

this was communicated by @knelasevero yesterday so we should be merging it soon

a7i avatar Mar 29 '24 20:03 a7i

cc: @jklaw90

a7i avatar Mar 29 '24 20:03 a7i

/lgtm

jklaw90 avatar Mar 29 '24 20:03 jklaw90