custom-metrics-apiserver
custom-metrics-apiserver copied to clipboard
kubernetes-sigs
Bump Kubernetes dependencies to v1.29.3
This issue is currently awaiting triage.
If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgrisonnet
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [dgrisonnet]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@dgrisonnet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-custom-metrics-apiserver-test | 0f61562f0df927c1781b05c0ab7aa7b145dcbe2a | link | true | /test pull-custom-metrics-apiserver-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
It has a panic error inside pull-custom-metrics-apiserver-test
--- FAIL: TestApplyTo (1.71s)
--- FAIL: TestApplyTo/only-secure-port (1.71s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1577a9d]
goroutine 132 [running]:
testing.tRunner.func1.2({0x1d40020, 0x34a7ad0})
/usr/local/go/src/testing/testing.go:1545 +0x238
testing.tRunner.func1()
/usr/local/go/src/testing/testing.go:1548 +0x397
panic({0x1d40020?, 0x34a7ad0?})
/usr/local/go/src/runtime/panic.go:914 +0x21f
k8s.io/client-go/kubernetes.NewForConfig(0xc000190500?)
/home/prow/go/pkg/mod/k8s.io/[email protected]/kubernetes/clientset.go:461 +0x1d
sigs.k8s.io/custom-metrics-apiserver/pkg/cmd/options.(*CustomMetricsAdapterServerOptions).ApplyTo(0xc0002f3dc0, 0xc0007a9bf0)
/home/prow/go/src/sigs.k8s.io/custom-metrics-apiserver/pkg/cmd/options/options.go:103 +0x1cd
sigs.k8s.io/custom-metrics-apiserver/pkg/cmd/options.TestApplyTo.func1(0xc000682b60)
/home/prow/go/src/sigs.k8s.io/custom-metrics-apiserver/pkg/cmd/options/options_test.go:115 +0x1ce
testing.tRunner(0xc000682b60, 0xc0003dc410)
/usr/local/go/src/testing/testing.go:1595 +0xff
created by testing.(*T).Run in goroutine [131](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_custom-metrics-apiserver/168/pull-custom-metrics-apiserver-test/1773066633665843200#1:build-log.txt%3A131)
/usr/local/go/src/testing/testing.go:1648 +0x3ad
FAIL sigs.k8s.io/custom-metrics-apiserver/pkg/cmd/options 1.752s
ok sigs.k8s.io/custom-metrics-apiserver/pkg/dynamicmapper 0.016s
ok sigs.k8s.io/custom-metrics-apiserver/pkg/provider 0.011s
FAIL
make: *** [Makefile:108: test] Error 1
Hi. I'm trying to build a custom metrics adapter and it doesn't currently build (#167), and I can't find any combination of dependencies or versions that will let me keep working. I'm hoping this issue will clear those things up.
I started investigating the test error, and the function NewRecommendedConfig called in TestApplyTo is returning a *server.RecommendedConfig that contains a *ClientConfig which is nil. I don't know enough to know how to fix this problem, since I'm not sure if that's supposed to be an acceptable result.
If I can help move this along, please let me know how.
Superseded by https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/170