cri-tools icon indicating copy to clipboard operation
cri-tools copied to clipboard

Update golangci-lint to v1.59.1 and fix lints

Open saschagrunert opened this issue 1 year ago • 3 comments
trafficstars

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update the config and fix the intrange lints.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

saschagrunert avatar Jul 01 '24 09:07 saschagrunert

/approve /lgtm

kwilczynski avatar Jul 03 '24 18:07 kwilczynski

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

/approve /lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 03 '24 18:07 k8s-ci-robot

@kubernetes-sigs/cri-tools-maintainers PTAL

saschagrunert avatar Jul 10 '24 10:07 saschagrunert

Still looks good!

/approve /lgtm

kwilczynski avatar Jul 10 '24 11:07 kwilczynski

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

Still looks good!

/approve /lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 10 '24 11:07 k8s-ci-robot

@kubernetes-sigs/cri-tools-maintainers PTAL

saschagrunert avatar Jul 11 '24 11:07 saschagrunert

/approve /lgtm

kwilczynski avatar Jul 11 '24 11:07 kwilczynski

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 11 '24 11:07 k8s-ci-robot