controller-tools icon indicating copy to clipboard operation
controller-tools copied to clipboard

Custom Flag/Arg Parsing Library Fails On Octal-looking Strings

Open stevekuznetsov opened this issue 1 year ago • 10 comments

Randomly-generated tmpdirs used as outputs for CRD gen can trip up the options parser in this repo:

Error: unable to parse option \"output:crd:dir=./tmp.08cAgAZQNm/chart/crds\": [invalid digit '8' in octal literal (at <input>:1:7)]

stevekuznetsov avatar Feb 05 '24 20:02 stevekuznetsov

I believe I've seen this one before, and it's because the random part of the temp dir begins with a 0. We just made sure not to allow leading zeros

JoelSpeed avatar Feb 06 '24 09:02 JoelSpeed

@JoelSpeed yes, that's the bug. This repository has it's own bespoke argument parsing implementation, which is where the bug lives.

stevekuznetsov avatar Feb 06 '24 14:02 stevekuznetsov

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 06 '24 14:05 k8s-triage-robot