controller-tools icon indicating copy to clipboard operation
controller-tools copied to clipboard

Hide `// TODO:` from generated CRD.

Open kaovilai opened this issue 3 years ago • 12 comments

Would be awesome to be able to annotate each _types.go field if there is a TODO but without having it live in a CRD for end users to see.

kaovilai avatar Sep 26 '22 19:09 kaovilai

Related: #649

cbandy avatar Sep 30 '22 21:09 cbandy

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 29 '22 21:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 28 '23 22:01 k8s-triage-robot

/remove-lifecycle rotten

On Sat, Jan 28, 2023, 5:52 PM Kubernetes Triage Robot < @.***> wrote:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Please send feedback to sig-contributor-experience at kubernetes/community https://github.com/kubernetes/community.

/lifecycle rotten

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/controller-tools/issues/728#issuecomment-1407505416, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVVG6ABKQTDD2DZTTWBRT3WUWPLTANCNFSM6AAAAAAQWDBKIM . You are receiving this because you authored the thread.Message ID: @.***>

kaovilai avatar Jan 28 '23 22:01 kaovilai

Hi @kaovilai,

Would you like to work on a PR to propose this solution?

camilamacedo86 avatar Jan 31 '23 09:01 camilamacedo86

I'm open to it :)

On Tue, Jan 31, 2023, 4:45 AM Camila Macedo @.***> wrote:

Hi @kaovilai https://github.com/kaovilai,

Would you like to work on a PR to propose this solution?

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/controller-tools/issues/728#issuecomment-1410052654, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVVG6FYRBX3O6LVSDOOLALWVDNLLANCNFSM6AAAAAAQWDBKIM . You are receiving this because you were mentioned.Message ID: @.***>

kaovilai avatar Jan 31 '23 14:01 kaovilai

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 01 '23 14:05 k8s-triage-robot

/remove-lifecycle stale

kaovilai avatar May 01 '23 15:05 kaovilai

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 19 '24 11:01 k8s-triage-robot

unstale

kaovilai avatar Jan 19 '24 15:01 kaovilai

/remove-lifecycle stale

kaovilai avatar Jan 19 '24 18:01 kaovilai

/lifecycle frozen

I think it makes sense to strip TODOs like upstream. We don't want TODOs showing up in CRDs, especially if they are on types from k/k.

sbueringer avatar Apr 10 '24 09:04 sbueringer