controller-tools icon indicating copy to clipboard operation
controller-tools copied to clipboard

Feature Request: support array type for printcolumn

Open damnever opened this issue 3 years ago • 8 comments

It only show the first item of the array. Maybe we should support array type with custom separator, the default separator could be comma, e.g. "a,b,c".

damnever avatar Jan 06 '22 12:01 damnever

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 06 '22 13:04 k8s-triage-robot

/remove-lifecycle stale

damnever avatar Apr 07 '22 02:04 damnever

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 06 '22 03:07 k8s-triage-robot

🔢 /remove-lifecycle stale

damnever avatar Jul 06 '22 06:07 damnever

Unfortunately, the OpenAPI data-types which is used by CRD to define its additionalPrinterColumns does not support array type.

FillZpp avatar Jul 06 '22 07:07 FillZpp

@FillZpp I was wondering how Service implements this function:

NAME    TYPE            CLUSTER-IP      EXTERNAL-IP      PORT(S)                                                     
abc     ClusterIP        xxx            <none>           8080/TCP,8081/TCP                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ```

damnever avatar Jul 07 '22 08:07 damnever

@damnever That's different. The columns of those built-in resources are defined in kubectl logic, which can easily print any data they want. But CRD, on the other hand, can only define columns in additionalPrinterColumns with OpenAPI data-types.

FillZpp avatar Jul 07 '22 08:07 FillZpp

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 05 '22 09:10 k8s-triage-robot

Has someone considered proposing this change with OpenAPI? Would this be feasible to achieve?

pmalek avatar Oct 21 '22 08:10 pmalek

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 20 '22 09:11 k8s-triage-robot

Sad to see this is not supported. Is there a way to generate the string to show? Or since this is all client side, nothing much can be done?

Edit: NVM, just added another field to the status and referred to that for printing.

adyanth avatar Dec 11 '22 01:12 adyanth

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jan 10 '23 02:01 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 10 '23 02:01 k8s-ci-robot