controller-tools
controller-tools copied to clipboard
kubernetes-sigs
webhook generation hardcodes name and namespace
https://github.com/kubernetes-sigs/controller-tools/blob/9a9db70f732af8f2ed69184a6e849f25d8e5a05e/pkg/webhook/parser.go#L243
I'd like this to be configurable so that I don't have to use Kustomize to add prefixes.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-contributor-experience at kubernetes/community. /close
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-contributor-experience at kubernetes/community. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I run my webhook in a different namespace than system so also need to customize the namespace.
Looks like the [Mutating|Validating]WebhookConfigurations' name itself is also hardcoded. I also need to customize this.
I need to customize these because if I deploy two different controllers to the same cluster, I can't use controller-gen's generated files without modification since the [Mutating|Validating]WebhookConfigurations' own names and that of their .webhooks[].clientConfig.name and .webhooks[].clientConfig.name conflict with each other.
@sbueringer: Reopened this issue.
In response to this:
/reopen /lifecycle frozen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.