kubernetes-sigs
⚠ Move arguments from Watch() & Start() to Source objects
⚠️ depends on https://github.com/kubernetes-sigs/controller-runtime/pull/2686
This PR removes the argument pass-through that happens when starting a Source watch.
Now, the eventhandler is passed directly to the Source constructor function.
Additionally, the predicates are now passed to the handler.WithPredicates which returns a "filtered handler".
This UX change makes the setup of Sources more intuitive, makes it much easier to create a custom Source and makes Sources easier to reason about.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: inteon Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@inteon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-controller-runtime-apidiff | 98944019ace34b2d4f3a54d2abad5d6cb85ee258 | link | false | /test pull-controller-runtime-apidiff |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.