kubernetes-sigs
✨Priority to use apiserver-etcd-client certificate if present
What this PR does / why we need it: This PR aims to use apiserver-etcd-client secret to have a certificate during ETCD reconciliation. This is useful for External CA mode and more particularly to allow External Certificate Signing.
Which issue(s) this PR fixes Fixes #12585 Problem 1
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: moh2a / name: Mohammad Amla (d439765206411f1499b12a51afc04633ed2f05c5)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is currently missing an area label, which is used to identify the modified component when generating release notes.
Area labels can be added by org members by writing /area ${COMPONENT} in a comment
Please see the labels list for possible areas.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Welcome @moh2a!
It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @moh2a. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Dear maintainers,
This PR is probably not perfect, but it addresses an existing issue without making significant changes to the code.
It should have no impact on the current behavior except in the rare case where users have a secret named cluster-apiserver-etcd-client that is unrelated to the actual cluster.
I’m happy to wait for your feedback if you find this change relevant.
Thank you for your time and consideration.
generally seems fine to me, but you need to rebase and add area.
I would prefer if we discuss on the proposal first before we merge this PR (currently low bandwidth on my side)
generally seems fine to me, but you need to rebase and add area.
I would prefer if we discuss on the proposal first before we merge this PR (currently low bandwidth on my side)
this seems like adjacent work, but agreed that PRs fixing anything from a proposal should ideally be done after the proposal is merged first.
/hold xref: https://github.com/kubernetes-sigs/cluster-api/pull/12603#issuecomment-3406249409