cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

:seedling: Add validation for PREVIOUS_RELEASE_TAG in release-notes-tool

Open tsuzu opened this issue 5 months ago • 9 comments
trafficstars

What this PR does / why we need it: Add a validation logic for make release-notes

✅ Now Accepts:

  • tags/v1.0.0-alpha.1 (alpha pre-release)
  • tags/v1.0.0-beta.1 (beta pre-release)
  • tags/v1.0.0-rc.1 (release candidate)

❌ Now Rejects:

  • v1.0.0-alpha.1 (missing tags/ prefix)
  • tags/v1.0.0 (no pre-release identifier)
  • tags/v1.0.0-dev.1 (unsupported pre-release type)
  • invalid-version (malformed version)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #12278

/area release

tsuzu avatar Jun 19 '25 14:06 tsuzu

@chandankumar4 Is this a change you are expecting? I appreciate it if you review this PR. Thanks!

tsuzu avatar Jun 19 '25 14:06 tsuzu

/retest

tsuzu avatar Jun 19 '25 15:06 tsuzu

/lgtm

sivchari avatar Jun 23 '25 10:06 sivchari

LGTM label has been added.

Git tree hash: 73279cb64ee7f62263e788e108c8a03acd45214b

k8s-ci-robot avatar Jun 23 '25 10:06 k8s-ci-robot

LGTM label has been added.

Git tree hash: b05a81d873f975ee74d3dd1511f4b7d5b0fd1592

k8s-ci-robot avatar Jun 25 '25 03:06 k8s-ci-robot

/retest

tsuzu avatar Jun 26 '25 18:06 tsuzu

/retest

tsuzu avatar Jun 28 '25 18:06 tsuzu

LGTM label has been added.

Git tree hash: 66fcd30dda4a5f40184e79bd834de9455d67f36b

k8s-ci-robot avatar Jun 29 '25 10:06 k8s-ci-robot

/lgtm

chandankumar4 avatar Jul 01 '25 18:07 chandankumar4

Thank you!

/lgtm /approve

sbueringer avatar Jul 07 '25 16:07 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 07 '25 16:07 k8s-ci-robot