cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

[WIP] ✨ Add support for v1beta2 conditions to clusterctl describe

Open fabriziopandini opened this issue 1 year ago • 2 comments

What this PR does / why we need it: Add supports for v1beta2 conditions to clusterctl describe

Which issue(s) this PR fixes*: Rif #11105

/area clusterctl

fabriziopandini avatar Oct 08 '24 21:10 fabriziopandini

Just some nits, otherwise lgtm

chrischdi avatar Nov 25 '24 09:11 chrischdi

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 4af631c3664060415859f4240e3c849b3468776f link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Nov 25 '24 12:11 k8s-ci-robot

/lgtm /approve

chrischdi avatar Nov 25 '24 12:11 chrischdi

LGTM label has been added.

Git tree hash: 6951351f264183d1d2ac69e7bc2b10f7cedea6cb

k8s-ci-robot avatar Nov 25 '24 12:11 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 25 '24 12:11 k8s-ci-robot