cluster-api
cluster-api copied to clipboard
kubernetes-sigs
🌱 Foreground deletion for machine deployments
What this PR does / why we need it: This PR enables foreground deletion of mds
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10710
Hi @Dhairya-Arora01. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Dhairya-Arora01: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-test-main | 0dc1cb08f8c69e01d1225213a72f3d14652db337 | link | true | /test pull-cluster-api-test-main |
| pull-cluster-api-e2e-blocking-main | 0dc1cb08f8c69e01d1225213a72f3d14652db337 | link | true | /test pull-cluster-api-e2e-blocking-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
(Will get around to reviewing it soon, I'm aware I got mentioned in a few places :))
@Dhairya-Arora01 Do you have time to address the findings above?
@sbueringer next week for sure!
@Dhairya-Arora01 Please let me know if you don't find the time to work on this. Happy to take over if necessary.
We have a few things that we have to implement on top of this PR that we want to implement pretty soon.
Thanks @Dhairya-Arora01 for kicking this off. Closing here in favour of:
- #11174
/close
@chrischdi: Closed this PR.
In response to this:
Thanks @Dhairya-Arora01 for kicking this off. Closing here in favour of:
- #11174
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.