cluster-api
cluster-api copied to clipboard
📖 release: restructure release docs team roles
What this PR does / why we need it:
This PR breaks up the lengthy release tasks doc by team as suggested in https://github.com/kubernetes-sigs/cluster-api/issues/10354
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10354
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: dhij / name: David Hwang (b5df22e1a62f388a1e423aafbd78753776cd332f, 9ae96b5c3f913562bafb45679ee7dc985146795f, 7ff1221647b0720db2dbee2051c5b962407abe4a, 1dce9ce7c4a6869848fb9fea976cdb7e27ac7de6, 560f8851de71cb3cd08ca5aaebd8df48d5a6a331, 8088c1e2e0154aee2200bbd96c4581f355980195, 122620949e3939aae6f667aa81ebc7b89daa11b8, 8092065afe56ca3bf303363ba3d79f98f99a9b71, 345a14fbbff13161eb78827a5ee7a08408b6435d, 52bb5f849868b6a7e3141c9e9d274b03da652d40, 9fc918df2beca5f662e4b27d78cbab8e11a4a56c)
Welcome @dhij!
It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @dhij. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/area documentation
/ok-to-test
@chrischdi I fixed the broken links and would appreciate if you could have a look 🙏
When this PR gets merged, I will need a follow-up PR to fix a bunch of broken links to release-tasks.md since that file would no longer exist (ex. in .github/ISSUE_TEMPLATE). I saw that including those link changes in this PR will break the CI since those are absolute https:// links.
@chrischdi I fixed the broken links and would appreciate if you could have a look 🙏
When this PR gets merged, I will need a follow-up PR to fix a bunch of broken links to
release-tasks.mdsince that file would no longer exist (ex. in.github/ISSUE_TEMPLATE). I saw that including those link changes in this PR will break the CI since those are absolutehttps://links.
Makes sense, maybe you can already prepare that PR so we can merge it quickly after this one to not break main for too long.
@dhij do you have time to address the finding?
@sbueringer thank you for the reminder, i will have a look at it now 👀
@chrischdi @sbueringer 👋 I have added the missing information and fixed the existing relative paths to the release-tasks.md file that does not exist anymore.
I also have a follow-up PR https://github.com/kubernetes-sigs/cluster-api/pull/10858 as Chris suggested to fix the other existing paths to release-tasks.md. Those changes could not be included in this same PR since they are absolute paths that will not exist until this PR is merged. Once this PR is merged, I will do a rebase on that PR 👍
@dhij Do you have time to address the findings above?
@sbueringer 👋 sorry for the delay, yes i will get to it 🙂
@chrischdi @sbueringer 👋 i addressed your comments and would appreciate another review 🙏
There were 3 new commits to the release-task.md in the meantime and since the release-task.md file is removed as part of this PR, I had to manually cherry-pick the changes into the new role-handbooks docs accordingly.
/lgtm /approve
Will do a small PR on-top after merging.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chrischdi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [chrischdi]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment