cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

[WIP] 📖 Add extra information in the supported labels and annotations tables

Open hackeramitkumar opened this issue 1 year ago • 2 comments
trafficstars

What this PR does / why we need it: I have sorted all of the labels and annotations in alphabatical order. And also added 2 new columns in the table, one for Manage By and other for the Applies to.

Which issue(s) this PR fixes Fixes #7441

/area documentation

hackeramitkumar avatar Apr 11 '24 19:04 hackeramitkumar

Hi @fabriziopandini ,

Thanks for reviewing the annotations and providing suggestions. I have resolved all the comments and made the suggested changes to the annotations. Could you please review the labels as well?

hackeramitkumar avatar Jun 05 '24 20:06 hackeramitkumar

cc @fabriziopandini ^°

sbueringer avatar Jul 10 '24 04:07 sbueringer

@fabriziopandini Sorry for the delay, I missed the notification. Now I have made the changes as per your suggestion. Please have a look. Thanks

hackeramitkumar avatar Aug 26 '24 16:08 hackeramitkumar

Thanks for the work on this PR @hackeramitkumar /lgtm /approve

/cherry-pick release-1.8

fabriziopandini avatar Aug 27 '24 09:08 fabriziopandini

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

Thanks for the work on this PR @hackeramitkumar /lgtm /approve

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

LGTM label has been added.

Git tree hash: 9ee382076a7db104153fe93f8ae97bb84753972e

k8s-ci-robot avatar Aug 27 '24 09:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 27 '24 09:08 k8s-ci-robot

@fabriziopandini: new pull request created: #11102

In response to this:

Thanks for the work on this PR @hackeramitkumar /lgtm /approve

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.