cluster-api
cluster-api copied to clipboard
🌱 Add MachinePools to handler and topology test
What this PR does / why we need it:
This PR adds MachinePools to the unit tests in handler_test.go and topology_test.go. This is a follow-up task to enabling MachinePools in ClusterClass.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes part of #10028
/area clusterclass
/lgtm
LGTM label has been added.
Thank you!!
/approve
Really appreciate your ongoing work on this!!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sbueringer
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [sbueringer]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest
Not sure what that was:
∅ test/extension
∅ test/extension/handlers/lifecycle
✖ test/extension/handlers/topologymutation
=== Failed
=== FAIL: test/extension/handlers/topologymutation (0.00s)
FAIL sigs.k8s.io/cluster-api/test/extension/handlers/topologymutation [build failed]
Let's see if it repeats
@willie-yao Can you please look into it? I'm guessing some compile error in tests (potentially only reproducible locally after rebase onto main)
@sbueringer Should be fixed now!
Thx!
/lgtm
LGTM label has been added.