cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

🌱 Add MachinePools to handler and topology test

Open willie-yao opened this issue 1 year ago • 1 comments

What this PR does / why we need it: This PR adds MachinePools to the unit tests in handler_test.go and topology_test.go. This is a follow-up task to enabling MachinePools in ClusterClass.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes part of #10028

/area clusterclass

willie-yao avatar Feb 29 '24 00:02 willie-yao

/lgtm

chrischdi avatar Apr 08 '24 09:04 chrischdi

LGTM label has been added.

Git tree hash: c29e4cb6cb3aa64f96118da448a7479ef189f654

k8s-ci-robot avatar Apr 08 '24 09:04 k8s-ci-robot

Thank you!!

/approve

Really appreciate your ongoing work on this!!

sbueringer avatar Apr 08 '24 17:04 sbueringer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 08 '24 17:04 k8s-ci-robot

/retest

sbueringer avatar Apr 08 '24 18:04 sbueringer

Not sure what that was:

∅  test/extension
∅  test/extension/handlers/lifecycle
✖  test/extension/handlers/topologymutation

=== Failed
=== FAIL: test/extension/handlers/topologymutation  (0.00s)
FAIL	sigs.k8s.io/cluster-api/test/extension/handlers/topologymutation [build failed]

Let's see if it repeats

sbueringer avatar Apr 08 '24 18:04 sbueringer

@willie-yao Can you please look into it? I'm guessing some compile error in tests (potentially only reproducible locally after rebase onto main)

sbueringer avatar Apr 08 '24 18:04 sbueringer

@sbueringer Should be fixed now!

willie-yao avatar Apr 08 '24 19:04 willie-yao

Thx!

/lgtm

sbueringer avatar Apr 08 '24 19:04 sbueringer

LGTM label has been added.

Git tree hash: 5aadfa98d957a8a4a5b10a33ca6c0469036bca20

k8s-ci-robot avatar Apr 08 '24 19:04 k8s-ci-robot