cluster-api icon indicating copy to clipboard operation
cluster-api copied to clipboard

🌱 Bump Go to 1.22.0

Open EmilienM opened this issue 1 year ago • 6 comments

What this PR does / why we need it:

Bump Go to 1.22.0. Upstream Kubernetes bumped last week: https://github.com/kubernetes/kubernetes/commit/ddb0b8da9dbcd3d507001c5cf8a01708816f3cd5

/area dependency

EmilienM avatar Feb 15 '24 14:02 EmilienM

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign killianmuldoon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 15 '24 14:02 k8s-ci-robot

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-verify-main 831b64866445504f03bbea450bf740a73e7794c0 link true /test pull-cluster-api-verify-main
pull-cluster-api-test-main 831b64866445504f03bbea450bf740a73e7794c0 link true /test pull-cluster-api-test-main
pull-cluster-api-e2e-blocking-main 831b64866445504f03bbea450bf740a73e7794c0 link true /test pull-cluster-api-e2e-blocking-main
pull-cluster-api-build-main 831b64866445504f03bbea450bf740a73e7794c0 link true /test pull-cluster-api-build-main
pull-cluster-api-apidiff-main 831b64866445504f03bbea450bf740a73e7794c0 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Feb 15 '24 14:02 k8s-ci-robot

/area dependency

EmilienM avatar Feb 15 '24 14:02 EmilienM

Note: upstream tracking issue:

  • https://github.com/kubernetes/release/issues/3280

We normally track bumping Go together with bumping k8s versions, xref: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/ISSUE_TEMPLATE/kubernetes_bump.md#using-new-kubernetes-dependencies

Prior art: #9900

chrischdi avatar Feb 15 '24 14:02 chrischdi

/hold

We should not bump to Go 1.22 ahead of consuming upstream dependencies like controller-runtime / k8s.io that have been tested with Go 1.22.

sbueringer avatar Feb 15 '24 14:02 sbueringer

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 12 '24 05:03 k8s-ci-robot

/close

EmilienM avatar Mar 23 '24 21:03 EmilienM

@EmilienM: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 23 '24 21:03 k8s-ci-robot