⚠️ Allow specifying a different credentials per VSphereMachine

[farodin91]

What this PR does / why we need it: Allow multiple vcenter in a single cluster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1720

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

I will try to test it.

Release note:

Allow custom identity in vmmachine

[k8s-ci-robot]

Hi @farodin91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: farodin91 / name: Jan Jansen (148ce73747cfc1278e0280aa4cb94b63bbd2edb3)

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[farodin91]

We are using this commit to migrate cluster from one vcenter to a different and it works just fine.

[farodin91]

/remove-lifecycle rotten

[farodin91]

@MaxRink would you like to look into this PR?

[farodin91]

@srm09 would you like to look into this PR?

[randomvariable]

We discussed this in the call of 2023/07/23:

• This will need to be marked as a breaking change, as there is a security implication of allowing users to create MachineDeployments targeting differing vcenters.
• We need an expansion of docs about how this works in a cluster and how to set up CPI and CSI in a cluster to make it work

cc @puneetkatyal

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign randomvariable for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[farodin91]

@randomvariable I started to write a documentation.

I added a link to external documentation for csi and cpi, do you think this is enough?

How should i mark this a breaking change?

[chrischdi]

/retitle ⚠️ Allow specifying a different credentials per VSphereMachine

(warning because of the security impact)

[farodin91]

@randomvariable Should i add this to commit message?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[guilhermevillote]

Any updates on this PR?

This is something very useful when your infrastructure has multiple vcenters and you constantly needs to migrate machines from one to another..

In this scenario, this PR is essential to adopt the CAPI.

Thanks

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[guilhermevillote]

Hi, any updates on this PR?

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[guilhermevillote]

/remove-lifecycle rotten

[guilhermevillote]

Do we have any estimate of when this change might be released?

[chrischdi]

I'm not actively working on this PR so I cannot give any estimate.

[farodin91]

@chrischdi @guilhermevillote If someone like to take over i'm fine. I don't have time at moment to fix it.

[chrischdi]

@chrischdi @guilhermevillote If someone like to take over i'm fine. I don't have time at moment to fix it.

Thanks @farodin91 !

/help

[sbueringer]

/close

Let's revive if someone has time & interest again

[k8s-ci-robot]

@sbueringer: Closed this PR.

In response to this:

/close

Let's revive if someone has time & interest again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[GabQ-Bib]

@sbueringer I would be interested in re-opening and working on this PR.