cluster-api-provider-packet
cluster-api-provider-packet copied to clipboard
kubernetes-sigs
✨ Add support for metros
What this PR does / why we need it: Adding metro support to packet cluster api crds
Which issue(s) this PR fixes Fixes https://github.com/kubernetes-sigs/cluster-api-provider-packet/issues/313
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: moadqassem
Once this PR has been reviewed and has the lgtm label, please assign detiber for approval by writing /assign @detiber in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
At first glance, this looks good, @moadqassem. We'll want to make sure that Facility is also Optional and check that one of the two fields has been provided (the fields are mutually exclusive in API Device create requests).
We should also use Metro-based deployment in one of the E2E tests.
@moadqassem https://github.com/moadqassem/cluster-api-provider-packet/pull/1. This is a WIP. I think there are a few more changes to make to ensure that Facility and Metro are mutually exclusive spec arguments with one of the two always required.
@moadqassem https://github.com/moadqassem/cluster-api-provider-packet/pull/1. This is a WIP. I think there are a few more changes to make to ensure that Facility and Metro are mutually exclusive spec arguments with one of the two always required.
Damn! Completely forgot about this. Let me convert it to WIP and will take care of it tomorrow 😉
Please refer back to #313 for some of the other todos we need to do here. Sounds like have a plan for the first one, and the last one just involves dropping the v1alpha3 stuff, but the others still need decisions.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: moadqassem Once this PR has been reviewed and has the lgtm label, please assign detiber for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Sounds like @moadqassem doesn't have time to work on this fork anymore, so we're going to take it over.
@cprivitere: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.