cluster-api-provider-openstack
cluster-api-provider-openstack copied to clipboard
✨Allow API Loadbalancer Health Monitor configuration
What this PR does / why we need it: Right now these values are hardcoded and the timeouts are too long, which can affect cluster poorly during control plane node outage / replacement.
/hold
Hi @pbasov. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
| Name | Link |
|---|---|
| Latest commit | e2f902d5d05141bcbceefb86113c72d9e8e33e04 |
| Latest deploy log | https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/687f5a7a21c17a000803020d |
| Deploy Preview | https://deploy-preview-2512--kubernetes-sigs-cluster-api-openstack.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
@lentzi90 @mdbooth ready for review
This is great! A real e2e test of this would be nice, as we discussed in the office hours. Would you be willing to add that also in this PR? I think this test should give a pretty good idea for how to do it.
PTAL on that e2e test when able, thanks
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lentzi90
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lentzi90]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment