cluster-api-provider-gcp
cluster-api-provider-gcp copied to clipboard
kubernetes-sigs
Simplify and reuse variables in `hack/tools/*.sh` scripts
/kind feature
Describe the solution you'd like
We have a few variables in CAPG that are being reused in every script. A good addition will be if we introduce a new script called common_vars.sh which will have all the common variables like KUBECTL, KIND, KUSTOMIZE , which will be referenced in the hack/tools*.sh scripts. This will simplify and reuse of the variables. I have seen this issue being raised in CAPZ and I feel this will be a great addition to CAPG as well.
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]
@sayantani11: This request has been marked as suitable for new contributors.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/good-first-issue /help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @sayantani11. Since there hasn't been any progress on this issue in a long time, I'd like to take it up.
/assign
Please is this issue still relevant? I saw that the last PR last linked to it was closed.
I actually went on to look for the script in hack/tools directory. I found some scripts in hack/ directory could those be the scripts that you are referring to?
@richardcase: Closing this issue.
In response to this:
Based on the comment in #749 :
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.