Remove Hardcoded failureDomain in Template

[evanfreed]

trafficstars

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes-sigs/cluster-api-provider-gcp/issues/683

Special notes for your reviewer:

TODOs:

• [x] squashed commits
• [ ] includes documentation
• [ ] adds unit tests

Release note:

Removes hardcoding failureDomain in the default cluster-template.yaml

Signed-off-by: Evan Freed [email protected]

/kind bug

[k8s-ci-robot]

Hi @evanfreed. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pydctw]

/ok-to-test

[evanfreed]

/test pull-cluster-api-provider-gcp-e2e-test

[pydctw]

@evanfreed, a great catch and thanks for the PR. The hard-coded failure domain is not need anymore.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, evanfreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [cpanato]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment