cluster-api-provider-gcp icon indicating copy to clipboard operation
cluster-api-provider-gcp copied to clipboard

Add codespell and fix spelling issues

Open evanfreed opened this issue 3 years ago • 4 comments
trafficstars

What type of PR is this?

/kind documentation /kind cleanup

What this PR does / why we need it:

Adds a Github Action for codespell and fixes existing issues in repository.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #681

Special notes for your reviewer:

If you'd like to test locally you can use something like act to locally run GH Actions (looks GH already picked up the check though 😄 ).

brew install act
act pull_request -j codespell

TODOs:

  • [ ] squashed commits
  • [x] includes documentation
  • [ ] adds unit tests

Release note:

-->

NONE

Signed-off-by: Evan Freed [email protected]

evanfreed avatar Aug 10 '22 17:08 evanfreed

Hi @evanfreed. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 10 '22 17:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: evanfreed Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval by writing /assign @justinsb in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 10 '22 17:08 k8s-ci-robot

/ok-to-test

cpanato avatar Aug 10 '22 17:08 cpanato

@evanfreed: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 21 '22 23:09 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: evanfreed Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato by writing /assign @cpanato in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 10 '22 15:11 k8s-ci-robot

This looks good to me, @evanfreed would you be able to squash your commits?

richardcase avatar Dec 14 '22 13:12 richardcase

/lgtm /approve

richardcase avatar Dec 14 '22 18:12 richardcase

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evanfreed, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 14 '22 18:12 k8s-ci-robot