kubernetes-sigs
Reconcile subnetworks
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #676
Special notes for your reviewer:
TODOs:
- [ ] squashed commits
- [ ] includes documentation
- [X] adds unit tests
Release note:
Network subnets are reconciled
Hi @fiunchinho. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Might be worth adding an example in https://github.com/kubernetes-sigs/cluster-api-provider-gcp/tree/main/docs/book/src/topics about custom defined CIDRs. I'm imagining something like Azure's book page.
@cpanato: GitHub didn't allow me to assign the following users: for, comments, and, reviews.
Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
lgtm as i can see, lets checkc the tests and e2e
some few nits
/assign @richardcase @pydctw for comments and reviews
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test pull-cluster-api-provider-gcp-build/test pull-cluster-api-provider-gcp-e2e-test/test pull-cluster-api-provider-gcp-make/test pull-cluster-api-provider-gcp-test/test pull-cluster-api-provider-gcp-verify
The following commands are available to trigger optional jobs:
/test pull-cluster-api-provider-gcp-apidiff/test pull-cluster-api-provider-gcp-capi-e2e/test pull-cluster-api-provider-gcp-conformance/test pull-cluster-api-provider-gcp-conformance-ci-artifacts/test pull-cluster-api-provider-gcp-coverage/test pull-cluster-api-provider-gcp-e2e-workload-upgrade
Use /test all to run the following jobs that were automatically triggered:
pull-cluster-api-provider-gcp-apidiffpull-cluster-api-provider-gcp-buildpull-cluster-api-provider-gcp-e2e-testpull-cluster-api-provider-gcp-makepull-cluster-api-provider-gcp-testpull-cluster-api-provider-gcp-verify
In response to this:
/test ls
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/test pull-cluster-api-provider-gcp-capi-e2e /test pull-cluster-api-provider-gcp-conformance /test pull-cluster-api-provider-gcp-conformance-ci-artifacts /test pull-cluster-api-provider-gcp-e2e-workload-upgrade
/test pull-cluster-api-provider-gcp-capi-e2e /test pull-cluster-api-provider-gcp-conformance /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
@fiunchinho: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-gcp-coverage | 3d04d0824b5c385d4342dc2e5e3f139ef89d66fb | link | false | /test pull-cluster-api-provider-gcp-coverage |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, fiunchinho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [cpanato]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment