kubernetes-sigs
Typo in README.md #487
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
- [x] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
Release note:
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
- If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
- Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
The committers are authorized under a signed CLA.
- :white_check_mark: Kelvin Euclides Pedro (c608ec0d4518425dd9919fdb11eaeb604476f54a, 23fe334a98ff76b1418f53b1427b1624f8a99f88, 81eb2659fa848bb40044f0b52d3bc01eea6b658d)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @KelvinEuclides!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @KelvinEuclides. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Also, you need to sign the CLA before we can proceed further with the tests.
@KelvinEuclides
7. My pull request still doesn't pass!
If you haven't yet, post a comment ("I signed it") to the PR—this is needed for the system to recheck your contribution authorization.
Each commit in the pull request needs to pass. If you have commits that didn't attribute to a Github username, or to a different user that hasn't signed the CLA, that will fail that commit and all subsequent commits.
@KelvinEuclides Just for the sake of it, can you also try "I signed it" with the quotations
I signed it
On Mon, 28/02/2022 at 17:37 Sayantani Saha @.***> wrote:
@KelvinEuclides https://github.com/KelvinEuclides Just for the sake of it, can you also try "I signed it"
— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/489#issuecomment-1054381857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4KA4BCRVWUY375BLDHXT3U5OJEHANCNFSM5MOSIW2A . You are receiving this because you were mentioned.Message ID: @.***>
@KelvinEuclides What @sayantani11 means to say is that you can just comment directly here the quote, I signed it , with double quotations marks. I guess that'll work.
Sorry ment to squash
On Sat, 5/03/2022 at 05:23 Kubernetes Prow Robot @.***> wrote:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: KelvinEuclides https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/489# To complete the pull request process https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process, please assign cecilerobertmichon after the PR has been reviewed. You can assign the PR to them by writing /assign @cecilerobertmichon in a comment when ready.
The full list of commands accepted by this bot can be found here https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fcluster-api-provider-gcp . Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment
— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/489#issuecomment-1059672577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4KA4CU4TELTUNT4LLYWSLU6LHURANCNFSM5MOSIW2A . You are receiving this because you were mentioned.Message ID: @.***>
humm sorry, just saw that it is still missing some changes
/lgtm cancel /approve cancel
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: KelvinEuclides To complete the pull request process, please ask for approval from cpanato after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@KelvinEuclides - just checking in, any chance of squashing commits on this?
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close