cluster-api-provider-gcp icon indicating copy to clipboard operation
cluster-api-provider-gcp copied to clipboard

Support Kubernetes 1.29+

Open mloiseleur opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

Related to #1331

Special notes for your reviewer:

Since we did not manage to get cloud-provider external works properly and it's not (yet) removed, I open this PR to (at least) provide a working Out Of the Box user XP when trying to start a Kubernetes 1.29+ cluster with this provider.

I'm not sure that documentation is needed, since it's already documented upstream.

TODOs:

  • [x] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

Release note:

Disable required feature gates for Kubernetes 1.29+

mloiseleur avatar Oct 17 '24 07:10 mloiseleur

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
Latest commit a04fd60aedb0f4619b18fda1ba64fc695642d6d3
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/6710b983762ee20008b40996
Deploy Preview https://deploy-preview-1333--kubernetes-sigs-cluster-api-gcp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 17 '24 07:10 netlify[bot]

Thanks @mloiseleur.

/lgtm

salasberryfin avatar Oct 25 '24 07:10 salasberryfin

/assign @richardcase

salasberryfin avatar Oct 25 '24 07:10 salasberryfin

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 25 '24 07:10 k8s-ci-robot

/cherry-pick release-1.8

cpanato avatar Oct 25 '24 07:10 cpanato

@cpanato: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato: new pull request created: #1346

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.