cluster-api-provider-gcp icon indicating copy to clipboard operation
cluster-api-provider-gcp copied to clipboard

For internal Load Balancer use the same API port as external LB

Open bfournie opened this issue 1 year ago • 4 comments
trafficstars

What type of PR is this? /kind bug

What this PR does / why we need it: Sets the API port used for the Internal Load Balancer to be the same as that used for the External Load Balancer.

Which issue(s) this PR fixes Fixes #1273

TODOs:

  • [x] squashed commits
  • [ ] includes documentation
  • [x] adds unit tests

Release note:

NONE

bfournie avatar Jul 02 '24 19:07 bfournie

Hi @bfournie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 02 '24 19:07 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
Latest commit 5d4d04879410ebb8de97cb1bbf07c512ef414bdc
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66a77b261b0b83000829e8d1
Deploy Preview https://deploy-preview-1282--kubernetes-sigs-cluster-api-gcp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 02 '24 19:07 netlify[bot]

/assign @damdo

/approve

cpanato avatar Jul 03 '24 13:07 cpanato

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 03 '24 13:07 k8s-ci-robot

@bfournie - this looks good. Would you be able to rebase so that we could get this in?

richardcase avatar Jul 29 '24 09:07 richardcase

/lgtm

richardcase avatar Aug 07 '24 10:08 richardcase