cluster-api-provider-gcp
cluster-api-provider-gcp copied to clipboard
kubernetes-sigs
add sharedvpc support for lb subnet
What type of PR is this?
What this PR does / why we need it:
Add support for SharedVPC when specifying spec.loadBalancer.internalLoadBalancer.subnet
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1279
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
- [x] squashed commits
- [x] includes documentation
- [x] adds unit tests
Release note:
NONE
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: swarren83 / name: Shawn Warren (0207069efe02b3d13c277879828b642b99145737)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @swarren83!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @swarren83. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
| Name | Link |
|---|---|
| Latest commit | 0207069efe02b3d13c277879828b642b99145737 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66902ec8420e0700071260b7 |
| Deploy Preview | https://deploy-preview-1280--kubernetes-sigs-cluster-api-gcp.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cpanato I signed the CLA yesterday and again today. I have received email confirmation both times. It states "This is a notification email from EasyCLA regarding the project OpenTelemetry." According to the docs it doesn't appear that EasyCLA is sending me to the correct agreement. Is there another way to sign the CLA?
I have opened a support case with LFX Support regarding EasyCLA issues I am experiencing.
The EasyCLA issue was that I signed with an email address that didn't match the one used to sign the CLA.
@cpanato I need to wait on merging this. I need to work on switching to the Corporate CLA.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, swarren83
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [cpanato]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Wanted to follow up on the status of this PR, @damdo do you have any additional requirements of me to earn your approval?
@barbacbd I have reverted the changes to scope regional health checks and target tcp proxies.
@barbacbd I have reverted the changes to scope regional health checks and target tcp proxies.
@swarren83 I would probably rebase it so that there is only one commit. Otherwise LGTM. @cpanato PTAL Thank you!
@barbacbd I rebased to a single commit as requested. Do we need anything else to get this ready to merge?
@barbacbd I rebased to a single commit as requested. Do we need anything else to get this ready to merge?
I am good with this change. I do not have LGTM or Approval privileges in this repo. @damdo or @cpanato can you take a look please?